[SPARK-8023] [SQL] Add a deterministic method to Expression. #6570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /** Returns true if any expression in projectList is non-deterministic. */ | ||
| private def hasNondeterministic(projectList: Seq[NamedExpression]): Boolean = { | ||
| projectList.exists(expr => expr.find(!_.deterministic).isDefined) |
There was a problem hiding this comment.
this won't match on rand() + 1 will this?
There was a problem hiding this comment.
This will match rand() + 1. find will traverse the expression tree in pre-order.
rxin
added a commit
to rxin/spark
that referenced
this pull request
Jun 2, 2015
[SPARK-8023] [SQL] Add a deterministic method to Expression.
|
Test build #33953 has finished for PR 6570 at commit
|
|
Test build #33955 has finished for PR 6570 at commit
|
asfgit
pushed a commit
that referenced
this pull request
Jun 2, 2015
…d collapsing nondeterministic projects. This closes #6570. Author: Yin Huai <[email protected]> Author: Reynold Xin <[email protected]> Closes #6573 from rxin/deterministic and squashes the following commits: 356cd22 [Reynold Xin] Added unit test for the optimizer. da3fde1 [Reynold Xin] Merge pull request #6570 from yhuai/SPARK-8023 da56200 [Yin Huai] Comments. e38f264 [Yin Huai] Comment. f9d6a73 [Yin Huai] Add a deterministic method to Expression. (cherry picked from commit 0f80990) Signed-off-by: Reynold Xin <[email protected]> Conflicts: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/random.scala
asfgit
pushed a commit
that referenced
this pull request
Jun 2, 2015
…d collapsing nondeterministic projects. This closes #6570. Author: Yin Huai <[email protected]> Author: Reynold Xin <[email protected]> Closes #6573 from rxin/deterministic and squashes the following commits: 356cd22 [Reynold Xin] Added unit test for the optimizer. da3fde1 [Reynold Xin] Merge pull request #6570 from yhuai/SPARK-8023 da56200 [Yin Huai] Comments. e38f264 [Yin Huai] Comment. f9d6a73 [Yin Huai] Add a deterministic method to Expression.
jeanlyn
pushed a commit
to jeanlyn/spark
that referenced
this pull request
Jun 12, 2015
…d collapsing nondeterministic projects. This closes apache#6570. Author: Yin Huai <[email protected]> Author: Reynold Xin <[email protected]> Closes apache#6573 from rxin/deterministic and squashes the following commits: 356cd22 [Reynold Xin] Added unit test for the optimizer. da3fde1 [Reynold Xin] Merge pull request apache#6570 from yhuai/SPARK-8023 da56200 [Yin Huai] Comments. e38f264 [Yin Huai] Comment. f9d6a73 [Yin Huai] Add a deterministic method to Expression.
nemccarthy
pushed a commit
to nemccarthy/spark
that referenced
this pull request
Jun 19, 2015
…d collapsing nondeterministic projects. This closes apache#6570. Author: Yin Huai <[email protected]> Author: Reynold Xin <[email protected]> Closes apache#6573 from rxin/deterministic and squashes the following commits: 356cd22 [Reynold Xin] Added unit test for the optimizer. da3fde1 [Reynold Xin] Merge pull request apache#6570 from yhuai/SPARK-8023 da56200 [Yin Huai] Comments. e38f264 [Yin Huai] Comment. f9d6a73 [Yin Huai] Add a deterministic method to Expression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SPARK-8023